summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKrešimir Čohar <[email protected]>2018-11-19 07:45:52 -0700
committerNate Graham <[email protected]>2018-11-19 07:46:51 -0700
commitdfce50030dd987a406d3d5043c572b4c2d477b6c (patch)
tree1a90b6ca4034b6d1c27bcc7367c6f3d5a59f8072
parent7caafc8f58487debb3950a7f457f2dcb832b8003 (diff)
[Kickoff] Make Kickoff separators leaner (less opaque) and narrower (the length of a highlighted menu item)
Summary: Leaner separators in Kickoff (less opaque/more see-through, narrower/shorter) Test Plan: This patch would spruce up the much-needed separators in Kickoff that were discussed in D15011 and ultimately added in D15206. It would reduce the opacity of the separators by almost half and make the top separator (between the search field and the rest of the Kickoff menu) as long/wide as a highlighted menu item. This variant was actually put forward in D15011. >>! In D15011#314514, @ngraham wrote: > Perhaps the white background and blinking cursor appear too attention-getting in comparison to the rest of Kickoff, which tries very hard to be flat and gray and avoid separators (e.g. between the different sections and the tab bar at the bottom or the header on top). I wonder if we wouldn't feel like the search field was so jarring if there were better differentiation between other elements. For example: > > {F6212312} > See the difference in the screenshots below: {F6427577} {F6427578} Reviewers: ngraham, #vdg, romangg Reviewed By: ngraham, #vdg, romangg Subscribers: romangg, filipf, plasma-devel Tags: #plasma Differential Revision: https://phabricator.kde.org/D16937
-rw-r--r--applets/kickoff/package/contents/ui/FullRepresentation.qml5
-rw-r--r--applets/kickoff/package/contents/ui/KickoffListView.qml9
2 files changed, 8 insertions, 6 deletions
diff --git a/applets/kickoff/package/contents/ui/FullRepresentation.qml b/applets/kickoff/package/contents/ui/FullRepresentation.qml
index 517d86c..36b8fe7 100644
--- a/applets/kickoff/package/contents/ui/FullRepresentation.qml
+++ b/applets/kickoff/package/contents/ui/FullRepresentation.qml
@@ -121,8 +121,8 @@ Item {
height: Math.floor(units.devicePixelRatio)
color: Qt.tint(PlasmaCore.ColorScope.textColor, Qt.rgba(PlasmaCore.ColorScope.backgroundColor.r, PlasmaCore.ColorScope.backgroundColor.g, PlasmaCore.ColorScope.backgroundColor.b, 0.7))
-
- width: root.width
+ opacity: 0.6
+ width: root.width - 2 * units.gridUnit
anchors {
top: header.top
@@ -480,6 +480,7 @@ Item {
width: root.width
height: Math.floor(units.devicePixelRatio)
color: Qt.tint(PlasmaCore.ColorScope.textColor, Qt.rgba(PlasmaCore.ColorScope.backgroundColor.r, PlasmaCore.ColorScope.backgroundColor.g, PlasmaCore.ColorScope.backgroundColor.b, 0.7))
+ opacity: 0.6
anchors {
top: header.top
diff --git a/applets/kickoff/package/contents/ui/KickoffListView.qml b/applets/kickoff/package/contents/ui/KickoffListView.qml
index 3db7063..13e9012 100644
--- a/applets/kickoff/package/contents/ui/KickoffListView.qml
+++ b/applets/kickoff/package/contents/ui/KickoffListView.qml
@@ -54,19 +54,20 @@ FocusScope {
listView.decrementCurrentIndex();
}
+
PlasmaExtras.ScrollArea {
id: scrollArea
-
+ frameVisible: false
anchors.fill: parent
ListView {
id: listView
-
+
focus: true
-
+
keyNavigationWraps: true
boundsBehavior: Flickable.StopAtBounds
-
+
highlight: KickoffHighlight {}
highlightMoveDuration : 0
highlightResizeDuration: 0