summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKai Uwe Broulik <kde@privat.broulik.de>2017-01-09 07:28:16 (GMT)
committerKai Uwe Broulik <kde@privat.broulik.de>2017-01-09 07:28:16 (GMT)
commitd2fde361d3c8fb40fb6c1e53e4178042799b6691 (patch)
treea9d479a4e0062a0cc5b2e577ea9893902ddd846e
parent180e1072e933cf13edb145dfeab2a62b7623a0eb (diff)
[Folder View] Fix right click erroneously opening files
It turns out mouse.buttons is 0 for "clicked" events whereas mouse.button is properly set. It should bail out when released with right mouse button as that opens the context menu but this condition is never met. According to documentation this looks intentional, at least it says "For mouse move events […]. For mouse press and double click events […]. For mouse release events […]." I can see no mention of regular "clicked", no idea why that is, though. BUG: 360219 FIXED-IN: 5.8.6
-rw-r--r--containments/desktop/package/contents/ui/FolderView.qml2
1 files changed, 1 insertions, 1 deletions
diff --git a/containments/desktop/package/contents/ui/FolderView.qml b/containments/desktop/package/contents/ui/FolderView.qml
index 9588306..3dd1343 100644
--- a/containments/desktop/package/contents/ui/FolderView.qml
+++ b/containments/desktop/package/contents/ui/FolderView.qml
@@ -233,7 +233,7 @@ Item {
onClicked: {
clearPressState();
- if (mouse.buttons & Qt.RightButton ||
+ if (mouse.button === Qt.RightButton ||
childAt(mouse.x, mouse.y) == editor) {
return;
}