summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKai Uwe Broulik <kde@privat.broulik.de>2017-01-03 08:35:05 (GMT)
committerKai Uwe Broulik <kde@privat.broulik.de>2017-01-03 08:35:05 (GMT)
commit76ac242c37b71b7dcdfaa4f78afd365b43610d6f (patch)
tree90336e32f1b62e89a006028d85c304b6dc9993de
parente80a4b87cfa98708724942794ca6f051974bb5c0 (diff)
[Containment Appearance] Make sure to always load a config view
If StackView is empty, currentItem will be null and we would break all over the place. This can happen when you have a wallpaper without config, so "sourceFile" would stay empty and thus onSourceFileChanged wouldn't be triggered and we wouldn't load anything into our StackView. BUG: 360862 FIXED-IN: 5.8.6 Differential Revision: https://phabricator.kde.org/D3911
-rw-r--r--desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml5
1 files changed, 4 insertions, 1 deletions
diff --git a/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml b/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
index 91b4d5c..032d6a2 100644
--- a/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
+++ b/desktoppackage/contents/configuration/ConfigurationContainmentAppearance.qml
@@ -134,7 +134,10 @@ ColumnLayout {
left: parent.left;
right: parent.right;
}
- property string sourceFile
+ // Bug 360862: if wallpaper has no config, sourceFile will be ""
+ // so we wouldn't load emptyConfig and break all over the place
+ // hence set it to some random value initially
+ property string sourceFile: "tbd"
onSourceFileChanged: {
if (sourceFile) {
var props = {}