diff options
authorHartmut Riesenbeck <[email protected]>2017-12-07 21:12:03 +0100
committerHartmut Riesenbeck <[email protected]>2017-12-11 21:13:58 +0100
commitc931d920049395f17e84b0eb3ea7edeb35bdd085 (patch)
parent21da13e7411288f03f637166fc516f4c58131765 (diff)
[Parley] Fix false error message when entering dashboard
Summary: When entering dashboard with conjugations as current practice mode, an error message box is shown when no entries are due for practice. It says: "The vocabulary document contains no entries that can be used for the chosen type of practice." For determining the word count of the collection widgets, the EntryFilter class is used. A missing test for the showDialg flag was added in the conjugation entries evaluation. BUG: 387656 Reviewers: #kde_edu, apol Reviewed By: apol Subscribers: apol Tags: #kde_edu Differential Revision: https://phabricator.kde.org/D9246
1 files changed, 1 insertions, 1 deletions
diff --git a/src/collection/entryfilter.cpp b/src/collection/entryfilter.cpp
index a68c30d..5aa3d14 100644
--- a/src/collection/entryfilter.cpp
+++ b/src/collection/entryfilter.cpp
@@ -148,7 +148,7 @@ QList<TestEntry*> EntryFilter::entries(bool showDialog)
// lists of EduVocTranslations.
if (Prefs::practiceMode() == Prefs::EnumPracticeMode::ConjugationPractice) {
QList< TestEntry* > ret = conjugationTestEntries(ignoreBlocked);
- if (ret.count() == 0) {
+ if ((ret.count() == 0) && showDialog) {
KMessageBox::error(0, noEntriesError);
return ret;