Improve test coverage of ReviewsModel test

And fix the problems while at it. :)

3 files changed, 13 insertions, 1 deletions

diff --git a/libmuon/ReviewsBackend/ReviewsModel.cpp b/libmuon/ReviewsBackend/ReviewsModel.cpp
index 4fd6e7a..6b948b0 100644
--- a/libmuon/ReviewsBackend/ReviewsModel.cpp
+++ b/libmuon/ReviewsBackend/ReviewsModel.cpp
@@ -97,6 +97,7 @@ void ReviewsModel::setResource(AbstractResource* app)
     if(m_app!=app) {
         beginResetModel();
         m_reviews.clear();
+        m_lastPage = 0;
         endResetModel();
 
         if(m_backend) {
diff --git a/libmuon/backends/DummyBackend/DummyReviewsBackend.cpp b/libmuon/backends/DummyBackend/DummyReviewsBackend.cpp
index 2745998..36b46a8 100644
--- a/libmuon/backends/DummyBackend/DummyReviewsBackend.cpp
+++ b/libmuon/backends/DummyBackend/DummyReviewsBackend.cpp
@@ -32,6 +32,9 @@ DummyReviewsBackend::DummyReviewsBackend(DummyBackend* parent)
 
 void DummyReviewsBackend::fetchReviews(AbstractResource* app, int page)
 {
+    if (page>=5)
+        return;
+
     QList<Review*> review;
     for(int i=0; i<33; i++) {
         review += new Review(app->name(), app->packageName(), "en_US", "good morning", "the morning is very good", "dummy",
diff --git a/libmuon/backends/DummyBackend/tests/DummyTest.cpp b/libmuon/backends/DummyBackend/tests/DummyTest.cpp
index 5bd3719..d3583c6 100644
--- a/libmuon/backends/DummyBackend/tests/DummyTest.cpp
+++ b/libmuon/backends/DummyBackend/tests/DummyTest.cpp
@@ -49,7 +49,7 @@ AbstractResourcesBackend* backendByName(ResourcesModel* m, const QString& name)
 DummyTest::DummyTest(QObject* parent): QObject(parent)
 {
     m_model = new ResourcesModel("muon-dummy-backend", this);
-//     new ModelTest(m_model, m_model);
+    new ModelTest(m_model, m_model);
 
     m_appBackend = backendByName(m_model, "DummyBackend");
 }
@@ -161,6 +161,7 @@ void DummyTest::testReviewsModel()
     QVERIFY(res);
 
     ReviewsModel m;
+    new ModelTest(&m, &m);
     m.setResource(res);
     m.fetchMore();
 
@@ -171,6 +172,13 @@ void DummyTest::testReviewsModel()
     QCOMPARE(ReviewsModel::UserChoice(m.data(m.index(0,0), ReviewsModel::UsefulChoice).toInt()), ReviewsModel::Yes);
     m.markUseful(0, false);
     QCOMPARE(ReviewsModel::UserChoice(m.data(m.index(0,0), ReviewsModel::UsefulChoice).toInt()), ReviewsModel::No);
+
+    res = m_model->resourceByPackageName("Dummy 2");
+    m.setResource(res);
+    m.fetchMore();
+
+    QSignalSpy spy(&m, &ReviewsModel::rowsChanged);
+    QVERIFY(m.rowCount()>0);
 }
 
 void DummyTest::testUpdateModel()