pkexec wants split arguments

BUG: 351311

1 files changed, 2 insertions, 5 deletions

diff --git a/libmuonapt/QAptActions.cpp b/libmuonapt/QAptActions.cpp
index c54ef69..7b82f67 100644
--- a/libmuonapt/QAptActions.cpp
+++ b/libmuonapt/QAptActions.cpp
@@ -392,14 +392,11 @@ void QAptActions::runSourcesEditor()
     QString pkexec = QStandardPaths::findExecutable("pkexec");
     QString editor = QStandardPaths::findExecutable("software-properties-kde");
 
+    arguments << pkexec << editor << QStringLiteral("--attach") % QString::number(winID);
     if (m_reloadWhenEditorFinished) {
-        editor.append(QLatin1String(" --dont-update --attach ") % QString::number(winID)); //krazy:exclude=spelling;
-    } else {
-        editor.append(QLatin1String(" --attach ") % QString::number(winID));
+        arguments << QStringLiteral("--dont-update");
     }
 
-    arguments << pkexec << editor;
-
     proc->setProgram(arguments);
     m_mainWindow->find(winID)->setEnabled(false);
     proc->start();