aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMartin Gräßlin <[email protected]>2016-11-07 15:57:00 +0100
committerMartin Gräßlin <[email protected]>2016-11-16 09:06:12 +0100
commit4783e45ab76a0a60866fe675adcd6fbabee95abe (patch)
tree85f53717a697163d9f4ec08afca5f1beef188fc7
parent40ad7ef4e95363ed6550a1e4aec03c4432b2fb29 (diff)
[libkwineffects] Remove EffectsHandler::registerPropertyType
Summary: There is no effect using this method. As it's X11 specific it should be removed. Internally the EffectsHandlerImpl still requires the method. Thus it's moved into the private part. Reviewers: #kwin, #plasma_on_wayland Subscribers: plasma-devel, kwin Tags: #plasma_on_wayland, #kwin Differential Revision: https://phabricator.kde.org/D3297
-rw-r--r--autotests/mock_effectshandler.h1
-rw-r--r--effects.h2
-rw-r--r--libkwineffects/kwineffects.h7
3 files changed, 1 insertions, 9 deletions
diff --git a/autotests/mock_effectshandler.h b/autotests/mock_effectshandler.h
index 5f9467f..3855892 100644
--- a/autotests/mock_effectshandler.h
+++ b/autotests/mock_effectshandler.h
@@ -175,7 +175,6 @@ public:
void registerAxisShortcut(Qt::KeyboardModifiers, KWin::PointerAxisDirection, QAction *) override {}
void registerGlobalShortcut(const QKeySequence &, QAction *) override {}
void registerPointerShortcut(Qt::KeyboardModifiers, Qt::MouseButton, QAction *) override {}
- void registerPropertyType(long int, bool) override {}
void reloadEffect(KWin::Effect *) override {}
void removeSupportProperty(const QByteArray &, KWin::Effect *) override {}
void reserveElectricBorder(KWin::ElectricBorder, KWin::Effect *) override {}
diff --git a/effects.h b/effects.h
index 9559fdd..564a6b2 100644
--- a/effects.h
+++ b/effects.h
@@ -174,7 +174,6 @@ public:
unsigned long xrenderBufferPicture() override;
QPainter* scenePainter() override;
void reconfigure() override;
- void registerPropertyType(long atom, bool reg) override;
QByteArray readRootProperty(long atom, long type, int format) const override;
xcb_atom_t announceSupportProperty(const QByteArray& propertyName, Effect* effect) override;
void removeSupportProperty(const QByteArray& propertyName, Effect* effect) override;
@@ -287,6 +286,7 @@ protected:
int next_window_quad_type;
private:
+ void registerPropertyType(long atom, bool reg);
typedef QVector< Effect*> EffectsList;
typedef EffectsList::const_iterator EffectsIterator;
EffectsList m_activeEffects;
diff --git a/libkwineffects/kwineffects.h b/libkwineffects/kwineffects.h
index 44b49d2..d92984d 100644
--- a/libkwineffects/kwineffects.h
+++ b/libkwineffects/kwineffects.h
@@ -1056,13 +1056,6 @@ public:
virtual QPainter *scenePainter() = 0;
virtual void reconfigure() = 0;
- /**
- Makes KWin core watch PropertyNotify events for the given atom,
- or stops watching if reg is false (must be called the same number
- of times as registering). Events are sent using Effect::propertyNotify().
- Note that even events that haven't been registered for can be received.
- */
- virtual void registerPropertyType(long atom, bool reg) = 0;
virtual QByteArray readRootProperty(long atom, long type, int format) const = 0;
/**
* @brief Announces support for the feature with the given name. If no other Effect