summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorAkarsh Simha <akarsh@kde.org>2016-09-28 07:09:50 (GMT)
committerAkarsh Simha <akarsh@kde.org>2016-09-29 02:20:26 (GMT)
commit7a5cca47ec521c39330a912e05c505ed2852495a (patch)
treec53e61203826e5577681bd13965a270f75195f47
parentaa7dda063f1221b472f321dbc3c53af5e2dfbac3 (diff)
FIXME comments and cosmetic changes
-rw-r--r--kstars/ksnumbers.cpp5
-rw-r--r--kstars/kstarsdbus.cpp2
-rw-r--r--kstars/oal/log.cpp8
3 files changed, 9 insertions, 6 deletions
diff --git a/kstars/ksnumbers.cpp b/kstars/ksnumbers.cpp
index dff36c4..b1e0b44 100644
--- a/kstars/ksnumbers.cpp
+++ b/kstars/ksnumbers.cpp
@@ -157,13 +157,14 @@ const int KSNumbers::amp[NUTTERMS][4] = {
KSNumbers::KSNumbers( long double jd ){
K.setD( 20.49552 / 3600. ); //set the constant of aberration
P.setD( 102.94719 ); // ecliptic longitude of earth's perihelion, source: http://nssdc.gsfc.nasa.gov/planetary/factsheet/earthfact.html; FIXME: We should correct this, as it changes with time. See the commit log for an order of magnitude estimate of the error.
+ // FIXME: FIXME above seems to have been addressed? What is deltaEcLong? -- asimha
computeConstantValues();
updateValues( jd );
}
void KSNumbers::computeConstantValues() {
- // Compute those nubmers that need to be computed only
+ // Compute those numbers that need to be computed only
// once.
//
// Ideally, these should be computed at compile-time. When we
@@ -214,6 +215,8 @@ void KSNumbers::updateValues( long double jd ) {
days = jd;
+ // FIXME: What is the source for these algorithms / polynomials / numbers? -- asimha
+
//Julian Centuries since J2000.0
T = ( jd - J2000 ) / 36525.;
diff --git a/kstars/kstarsdbus.cpp b/kstars/kstarsdbus.cpp
index c9898a6..62f5f3c 100644
--- a/kstars/kstarsdbus.cpp
+++ b/kstars/kstarsdbus.cpp
@@ -232,7 +232,7 @@ bool KStars::setGeoLocation( const QString &city, const QString &province, const
if ( province.isEmpty() )
qDebug() << QString("Error [D-Bus setGeoLocation]: city %1, %2 not found in database.").arg(city).arg(country);
else
- qDebug() << QString("Error [D-Bus setGeoLocation]: city %1, %2, %3 not found in database.").arg(city).arg(province).arg(country);
+ qDebug() << QString("Error [D-Bus setGeoLocation]: city %1, %2, %3 not found in database.").arg(city).arg(province).arg(country);
}
return cityFound;
diff --git a/kstars/oal/log.cpp b/kstars/oal/log.cpp
index 073043f..b1c1e2c 100644
--- a/kstars/oal/log.cpp
+++ b/kstars/oal/log.cpp
@@ -227,7 +227,7 @@ void OAL::Log::writeSite( OAL::Site *s ) {
}
void OAL::Log::writeSession( OAL::Session *s ) {
writer->writeStartElement( "session" );
- writer->writeAttribute( "id", s->id() );
+ writer->writeAttribute( "id", s->id() );
writer->writeStartElement( "begin" );
writer->writeCharacters( s->begin().date().toString( "yyyy-MM-dd" ) + 'T' + s->begin().time().toString( "hh:mm:ss" ) );
writer->writeEndElement();
@@ -250,7 +250,7 @@ void OAL::Log::writeSession( OAL::Session *s ) {
}
void OAL::Log::writeScope( OAL::Scope *s ) {
writer->writeStartElement( "scope" );
- writer->writeAttribute( "id", s->id() );
+ writer->writeAttribute( "id", s->id() );
writer->writeStartElement( "model" );
writer->writeCDATA( s->model() );
writer->writeEndElement();
@@ -278,7 +278,7 @@ void OAL::Log::writeScope( OAL::Scope *s ) {
}
void OAL::Log::writeEyepiece( OAL::Eyepiece *ep ) {
writer->writeStartElement( "eyepiece" );
- writer->writeAttribute( "id", ep->id() );
+ writer->writeAttribute( "id", ep->id() );
writer->writeStartElement( "model" );
writer->writeCDATA( ep->model() );
writer->writeEndElement();
@@ -401,7 +401,7 @@ void OAL::Log::readBegin( QString input ) {
void OAL::Log::readUnknownElement() {
while( ! reader->atEnd() ) {
reader->readNext();
-
+
if( reader->isEndElement() )
break;