summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMontel Laurent <[email protected]>2015-09-28 13:29:40 +0200
committerMontel Laurent <[email protected]>2015-09-28 13:29:40 +0200
commit5ae79af7d1dba2a16247e0173044cf4ee068b2f7 (patch)
tree53e20cdbd490dd54cbbc27b5dbdf69b56fcc129d
parentbaa35ce8f8cc2ecc5d5cc0d574d06b79558d8fbf (diff)
Clean up
-rw-r--r--messageviewer/src/header/fancyheaderstyle.cpp11
-rw-r--r--messageviewer/src/header/fancyheaderstyle.h5
-rw-r--r--messageviewer/src/header/plainheaderstyle.cpp14
-rw-r--r--messageviewer/src/header/plainheaderstyle.h2
4 files changed, 22 insertions, 10 deletions
diff --git a/messageviewer/src/header/fancyheaderstyle.cpp b/messageviewer/src/header/fancyheaderstyle.cpp
index 66008a1..6d1bfae 100644
--- a/messageviewer/src/header/fancyheaderstyle.cpp
+++ b/messageviewer/src/header/fancyheaderstyle.cpp
@@ -50,6 +50,17 @@ using namespace MessageViewer;
// Like PlainHeaderStyle, but with slick frames and background colours.
//
+FancyHeaderStyle::FancyHeaderStyle()
+ : HeaderStyle()
+{
+
+}
+
+FancyHeaderStyle::~FancyHeaderStyle()
+{
+
+}
+
const char *FancyHeaderStyle::name() const
{
return "fancy";
diff --git a/messageviewer/src/header/fancyheaderstyle.h b/messageviewer/src/header/fancyheaderstyle.h
index 092e6ad..eb225a7 100644
--- a/messageviewer/src/header/fancyheaderstyle.h
+++ b/messageviewer/src/header/fancyheaderstyle.h
@@ -25,10 +25,9 @@ namespace MessageViewer
class MESSAGEVIEWER_EXPORT FancyHeaderStyle : public HeaderStyle
{
- friend class HeaderStyle;
public:
- FancyHeaderStyle() : HeaderStyle() {}
- virtual ~FancyHeaderStyle() {}
+ FancyHeaderStyle();
+ virtual ~FancyHeaderStyle();
public:
const char *name() const Q_DECL_OVERRIDE;
diff --git a/messageviewer/src/header/plainheaderstyle.cpp b/messageviewer/src/header/plainheaderstyle.cpp
index 99aa916..e6e7d4a 100644
--- a/messageviewer/src/header/plainheaderstyle.cpp
+++ b/messageviewer/src/header/plainheaderstyle.cpp
@@ -29,8 +29,15 @@
using namespace MessageCore;
-namespace MessageViewer
+using namespace MessageViewer;
+
+PlainHeaderStyle::PlainHeaderStyle()
+ : HeaderStyle()
{
+
+}
+
+
//
// PlainHeaderStyle:
// show every header field on a line by itself,
@@ -77,10 +84,6 @@ QString PlainHeaderStyle::format(KMime::Message *message) const
}
if (strategy->showHeader(QStringLiteral("from"))) {
- /*FIXME(Andras) review if it is still needed
- if ( fromStr.isEmpty() ) // no valid email in from, maybe just a name
- fromStr = message->fromStrip(); // let's use that
- */
headerStr.append(i18n("From: ") +
StringUtil::emailAddrAsAnchor(message->from(), StringUtil::DisplayFullAddress, QString(), StringUtil::ShowLink));
if (!vCardName().isEmpty())
@@ -135,4 +138,3 @@ const char *MessageViewer::PlainHeaderStyle::name() const
return "plain";
}
-}
diff --git a/messageviewer/src/header/plainheaderstyle.h b/messageviewer/src/header/plainheaderstyle.h
index 992d576..b1d213d 100644
--- a/messageviewer/src/header/plainheaderstyle.h
+++ b/messageviewer/src/header/plainheaderstyle.h
@@ -26,7 +26,7 @@ namespace MessageViewer
class MESSAGEVIEWER_EXPORT PlainHeaderStyle : public HeaderStyle
{
public:
- PlainHeaderStyle() : HeaderStyle() {}
+ PlainHeaderStyle();
~PlainHeaderStyle() {}
public: