summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMontel Laurent <[email protected]>2017-10-15 07:38:08 +0200
committerMontel Laurent <[email protected]>2017-10-15 07:38:08 +0200
commit662764af89c6bc3a2e1052e8c77b185100ae01e6 (patch)
treecbbec020b36051680c2ceb1819f80fa9ccf79fc4
parentd6981299974031bd7aed4f8b228b2f8979ad7e4e (diff)
Use const'ref here
-rw-r--r--resources/dav/resource/setupwizard.cpp2
-rw-r--r--resources/imap/replacemessagejob.cpp2
-rw-r--r--resources/imap/replacemessagejob.h2
-rw-r--r--resources/pop3/autotests/pop3test.cpp2
-rw-r--r--resources/pop3/autotests/pop3test.h2
5 files changed, 5 insertions, 5 deletions
diff --git a/resources/dav/resource/setupwizard.cpp b/resources/dav/resource/setupwizard.cpp
index 12050db..79bcced 100644
--- a/resources/dav/resource/setupwizard.cpp
+++ b/resources/dav/resource/setupwizard.cpp
@@ -304,7 +304,7 @@ int PredefinedProviderPage::nextId() const
* ServerTypePage
*/
-bool compareServiceOffers(QPair<QString, QString> off1, QPair<QString, QString> off2)
+bool compareServiceOffers(const QPair<QString, QString> &off1, const QPair<QString, QString> &off2)
{
return off1.first.toLower() < off2.first.toLower();
}
diff --git a/resources/imap/replacemessagejob.cpp b/resources/imap/replacemessagejob.cpp
index 41dee4d..fdf0875 100644
--- a/resources/imap/replacemessagejob.cpp
+++ b/resources/imap/replacemessagejob.cpp
@@ -29,7 +29,7 @@
#include "imapflags.h"
-ReplaceMessageJob::ReplaceMessageJob(const KMime::Message::Ptr &msg, KIMAP::Session *session, const QString &mailbox, qint64 uidNext, KIMAP::ImapSet oldUids, QObject *parent)
+ReplaceMessageJob::ReplaceMessageJob(const KMime::Message::Ptr &msg, KIMAP::Session *session, const QString &mailbox, qint64 uidNext, const KIMAP::ImapSet &oldUids, QObject *parent)
: KJob(parent),
mSession(session),
mMessage(msg),
diff --git a/resources/imap/replacemessagejob.h b/resources/imap/replacemessagejob.h
index 821e0b8..2559b08 100644
--- a/resources/imap/replacemessagejob.h
+++ b/resources/imap/replacemessagejob.h
@@ -32,7 +32,7 @@ class ReplaceMessageJob : public KJob
{
Q_OBJECT
public:
- ReplaceMessageJob(const KMime::Message::Ptr &msg, KIMAP::Session *session, const QString &mailbox, qint64 uidNext = -1, KIMAP::ImapSet oldUids = KIMAP::ImapSet(), QObject *parent = nullptr);
+ ReplaceMessageJob(const KMime::Message::Ptr &msg, KIMAP::Session *session, const QString &mailbox, qint64 uidNext = -1, const KIMAP::ImapSet &oldUids = KIMAP::ImapSet(), QObject *parent = nullptr);
qint64 newUid() const;
diff --git a/resources/pop3/autotests/pop3test.cpp b/resources/pop3/autotests/pop3test.cpp
index efdfb97..538c325 100644
--- a/resources/pop3/autotests/pop3test.cpp
+++ b/resources/pop3/autotests/pop3test.cpp
@@ -212,7 +212,7 @@ static const QByteArray simpleMail5 =
"\r\n"
"Hello World!!\r\n";
-void Pop3Test::cleanupMaildir(Akonadi::Item::List items)
+void Pop3Test::cleanupMaildir(const Akonadi::Item::List &items)
{
// Delete all mails so the maildir is clean for the next test
if (!items.isEmpty()) {
diff --git a/resources/pop3/autotests/pop3test.h b/resources/pop3/autotests/pop3test.h
index b886957..f5fe06b 100644
--- a/resources/pop3/autotests/pop3test.h
+++ b/resources/pop3/autotests/pop3test.h
@@ -48,7 +48,7 @@ private Q_SLOTS:
private:
void lowerTimeOfSeenMail(const QString &uidOfMail, int secondsToLower);
- void cleanupMaildir(Akonadi::Item::List items);
+ void cleanupMaildir(const Akonadi::Item::List &items);
void checkMailsInMaildir(const QList< QByteArray > &mails);
Akonadi::Item::List checkMailsOnAkonadiServer(const QList<QByteArray> &mails);
void syncAndWaitForFinish();