summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorWolfgang Rohdewald <wolfgang@rohdewald.de>2016-08-25 15:34:06 (GMT)
committerWolfgang Rohdewald <wolfgang@rohdewald.de>2016-08-25 16:57:24 (GMT)
commit05f73d45f212859b9f99554813828c09277ba7ad (patch)
treea7eff7ad14157f7b08773ee438b2b8582dcb1bbd
parentaa2822335529cc4c3bab32cc3cccced7eef68e76 (diff)
remove a few TODOs, put some of them into the TODO File
-rw-r--r--src/board.py6
-rw-r--r--src/chat.py1
-rw-r--r--src/common.py3
-rw-r--r--src/dialogs.py4
-rw-r--r--src/kdestub.py1
-rw-r--r--src/qt5.py1
-rwxr-xr-xsrc/scoringtest.py1
7 files changed, 4 insertions, 13 deletions
diff --git a/src/board.py b/src/board.py
index 0af0759..33a98b2 100644
--- a/src/board.py
+++ b/src/board.py
@@ -110,7 +110,7 @@ class PlayerWind(QGraphicsEllipseItem):
def setWind(self, name, roundsFinished):
"""change the wind"""
- assert isinstance(name, Wind) and name.svgName, 'name {} must be a real Wind but is {}'.format(
+ assert isinstance(name, Wind) and name.svgName, 'name {} must be a real Wind but is {}'.format(
name, type(name))
self.name = name
if isinstance(roundsFinished, bool):
@@ -771,8 +771,6 @@ class SelectorBoard(CourtBoard):
else:
result.append(lowerName.kong)
result.append(lowerName.kong.exposedClaimed)
- # TODO: old bug: move 3 identical hidden chows to east, then move
- # one of them to south exposed
if wantedTile.isNumber and wantedTile.value < 8:
chow2 = scName.nextForChow
chow3 = chow2.nextForChow
@@ -990,8 +988,6 @@ class DiscardBoard(CourtBoard):
def dropEvent(self, event):
"""drop a uiTile into the discard board"""
- # TODO: now that tiles are top level scene items, maybe drag them
- # directly. Draggings melds: QGraphicsItemGroup?
uiTile = event.mimeData().uiTile
assert isinstance(uiTile, UITile), uiTile
uiTile.setPos(event.scenePos() - uiTile.boundingRect().center())
diff --git a/src/chat.py b/src/chat.py
index b522d33..22c442b 100644
--- a/src/chat.py
+++ b/src/chat.py
@@ -196,7 +196,6 @@ class ChatWindow(QWidget):
def leave(self):
"""leaving the chat"""
- # TODO: send "left" message
self.hide()
def receiveLine(self, chatLine):
diff --git a/src/common.py b/src/common.py
index 1c62d60..a98c5f6 100644
--- a/src/common.py
+++ b/src/common.py
@@ -346,7 +346,6 @@ class IntDict(defaultdict, StrMixin):
return result
def __eq__(self, other):
- # TODO: could be optimized for speed
return self.all() == other.all()
def __ne__(self, other):
@@ -437,8 +436,6 @@ def unicodeString(s, encoding='utf-8'):
elif hasattr(s, 'decode'):
return s.decode(encoding)
else:
-# TODO: auf s5 testen mit ./kajonggtest.py --game=8001 --ruleset=DMJL
-# --git=a46635d..23aca3b --log --clients=2 --servers=2 --count=4
return repr(s)
diff --git a/src/dialogs.py b/src/dialogs.py
index 5c5b87e..b9420a0 100644
--- a/src/dialogs.py
+++ b/src/dialogs.py
@@ -86,7 +86,9 @@ class Prompt(MustChooseKDialog):
def __init__(self, msg, icon=QMessageBox.Information,
buttons=KDialog.Ok, caption=None, default=None):
"""buttons is button codes or-ed like KDialog.Ok | KDialog.Cancel. First one is default."""
- msg = msg.replace(r'\n', '\n') # TODO: where does this come from?
+ if r'\n' in msg:
+ logDebug(r'Fix this! Prompt gets \n in', msg)
+ msg = msg.replace(r'\n', '\n')
self.msg = msg
self.default = default
if Options.gui:
diff --git a/src/kdestub.py b/src/kdestub.py
index 319bf8c..71cca65 100644
--- a/src/kdestub.py
+++ b/src/kdestub.py
@@ -1078,7 +1078,6 @@ class KConfig(SafeConfigParser):
self.path = str(path)
if os.path.exists(self.path):
with codecs.open(self.path, 'r', encoding='utf-8') as cfgFile:
- # TODO: changed from 'rb' to 'r', test this!
if isPython3:
self.read_file(cfgFile)
else:
diff --git a/src/qt5.py b/src/qt5.py
index b59f4ef..a6feb16 100644
--- a/src/qt5.py
+++ b/src/qt5.py
@@ -129,7 +129,6 @@ from PyQt5.QtSvg import QSvgRenderer
from qstring import QString
KLineEdit = QLineEdit # pylint: disable=invalid-name
-# TODO: where?
def variantValue(variant):
"""convert QVariant to python variable"""
diff --git a/src/scoringtest.py b/src/scoringtest.py
index 7b36253..5efe7c9 100755
--- a/src/scoringtest.py
+++ b/src/scoringtest.py
@@ -940,7 +940,6 @@ class CallingHands(Base):
"""diverse calling hands"""
def testMe(self):
- # TODO: try assigning them to specif rule tests"""
self.callingTest('s1s1s1s1 b5b6b7 RB1B8C2C2C6C7C8 Lb5', '')
self.callingTest('WnWn B1 B2 c4c5c6 b6b6b6 b8b8b8 ye yw', ['b3', ''])
self.callingTest('WnWn B1 B2 dgdgdg b6b6b6 b8b8b8 ye yw', 'b3')