diff options
authorAlbert Astals Cid <[email protected]>2015-12-01 22:37:07 +0100
committerAlbert Astals Cid <[email protected]>2015-12-01 22:37:07 +0100
commite9843a8c71360bf38b1e7f289e4b6be2526d7a2d (patch)
parent68f3cfc4b631a2a9fc218138a347e9ec82bfe251 (diff)
Call KLocalizedString::setApplicationDomain("dragonplayer");
dragonplayer is using -DTRANSLATION_DOMAIN=\"dragonplayer\" that is wrong for applications, apps need to use KLocalizedString::setApplicationDomain since that is needed for some things like the transltators tab in the about dialog. I have not removed -DTRANSLATION_DOMAIN=\"dragonplayer\" because on the other hand this code is also a library (i.e. the dragonplayer kpart). The "being pedanticly correct" fix would be using -DTRANSLATION_DOMAIN=\"dragonplayer\" only to compile the files that are part of the kpart but that's prone to break at some point and using both KLocalizedString::setApplicationDomain and -DTRANSLATION_DOMAIN does not create any problem so i went that route CCMAIL: [email protected]
1 files changed, 2 insertions, 0 deletions
diff --git a/src/app/main.cpp b/src/app/main.cpp
index 2de3b35..809aa3e 100644
--- a/src/app/main.cpp
+++ b/src/app/main.cpp
@@ -36,6 +36,8 @@ int main( int argc, char **argv )
Dragon::PlayerApplication app(argc, argv);
+ KLocalizedString::setApplicationDomain("dragonplayer");
KAboutData aboutData( APP_NAME, i18n("Dragon Player"), QLatin1Literal(APP_VERSION),
i18n("A video player that has a usability focus"), KAboutLicense::GPL_V2,
i18n("Copyright 2006, Max Howell\nCopyright 2007, Ian Monroe"),