summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorNathaniel Graham <[email protected]>2018-03-21 17:00:17 -0600
committerNathaniel Graham <[email protected]>2018-03-22 06:52:11 -0600
commitf728d728649681bef78d53ea3b96d8dc2461a19a (patch)
treeaec8bf3aa8eb7fb43977644c1d84ee49c20fe7e1
parent1da0983c42a1ccd8034d411b87694753b5f9e9e6 (diff)
Fix missing entries in context menu for linksv18.03.80
Summary: https://cgit.kde.org/dolphin.git/commit/?id=86f4fcb8cd574f6d886627fc5e01c9edfc84e977 introduced a regression: the context menu for links no longer shows various items that were gated behind being a directory. However, a link can be both a link and a directory, from KIO's perspective. This patch resolves the issue. Test Plan: - Context menus for files, folders, and file links are unchanged. - The missing context menu items for folder links have returned: {F5761809} I should have tested that patch better, and for that I apologize and offer to fix this regression here. I will endeavor to up my reviewing game. Reviewers: rominf, michaelh, #dolphin, rkflx Reviewed By: rominf, rkflx Subscribers: rkflx Differential Revision: https://phabricator.kde.org/D11562
-rw-r--r--src/dolphincontextmenu.cpp3
1 files changed, 2 insertions, 1 deletions
diff --git a/src/dolphincontextmenu.cpp b/src/dolphincontextmenu.cpp
index fbd62ad..4801aa3 100644
--- a/src/dolphincontextmenu.cpp
+++ b/src/dolphincontextmenu.cpp
@@ -196,7 +196,8 @@ void DolphinContextMenu::openItemContextMenu()
if (m_fileInfo.isLink()) {
addAction(m_mainWindow->actionCollection()->action(QStringLiteral("show_target")));
addSeparator();
- } else if (m_fileInfo.isDir()) {
+ }
+ if (m_fileInfo.isDir()) {
// setup 'Create New' menu
DolphinNewFileMenu* newFileMenu = new DolphinNewFileMenu(m_mainWindow->actionCollection(), m_mainWindow);
const DolphinView* view = m_mainWindow->activeViewContainer()->view();