summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorElvis Angelaccio <[email protected]>2018-02-03 22:21:30 +0100
committerElvis Angelaccio <[email protected]>2018-02-03 22:21:30 +0100
commitbf1081a824d9024a400d2ac2437f169c6765caa5 (patch)
tree2905c41c966739469d86bcfd67b9678a1f020d9a
parentcef4d96cc6ed30284815320b1f7ddb59f201589e (diff)
Fix all 'explicit constructor' krazy warnings
-rw-r--r--src/dolphinpart_ext.h8
-rw-r--r--src/kitemviews/kfileitemlistview.h2
-rw-r--r--src/kitemviews/kitemlistgroupheader.h2
-rw-r--r--src/kitemviews/kitemlistheader.h2
-rw-r--r--src/kitemviews/kitemlistselectionmanager.h2
-rw-r--r--src/kitemviews/kitemlistview.h2
-rw-r--r--src/kitemviews/kitemmodelbase.h2
-rw-r--r--src/kitemviews/kitemrange.h2
-rw-r--r--src/kitemviews/kitemset.h2
-rw-r--r--src/kitemviews/kstandarditemlistgroupheader.h2
-rw-r--r--src/kitemviews/kstandarditemlistview.h2
-rw-r--r--src/kitemviews/private/kfileitemmodeldirlister.h2
-rw-r--r--src/kitemviews/private/kitemlistheaderwidget.h2
-rw-r--r--src/kitemviews/private/kitemlistkeyboardsearchmanager.h2
-rw-r--r--src/kitemviews/private/kitemlistselectiontoggle.h2
-rw-r--r--src/kitemviews/private/kitemlistsizehintresolver.h2
-rw-r--r--src/kitemviews/private/kitemlistviewanimation.h2
-rw-r--r--src/kitemviews/private/kitemlistviewlayouter.h2
-rw-r--r--src/middleclickactioneventfilter.h2
-rw-r--r--src/panels/information/phononwidget.h2
-rw-r--r--src/panels/places/placesitemlistgroupheader.h2
-rw-r--r--src/settings/general/confirmationssettingspage.h2
-rw-r--r--src/settings/general/previewssettingspage.h2
-rw-r--r--src/settings/general/statusbarsettingspage.h2
-rw-r--r--src/settings/navigation/navigationsettingspage.h2
-rw-r--r--src/settings/services/servicessettingspage.h2
-rw-r--r--src/settings/trash/trashsettingspage.h2
-rw-r--r--src/settings/viewmodes/dolphinfontrequester.h2
-rw-r--r--src/settings/viewmodes/viewmodesettings.h2
-rw-r--r--src/settings/viewmodes/viewsettingspage.h2
-rw-r--r--src/statusbar/dolphinstatusbar.h2
-rw-r--r--src/views/tooltips/dolphinfilemetadatawidget.h2
32 files changed, 35 insertions, 35 deletions
diff --git a/src/dolphinpart_ext.h b/src/dolphinpart_ext.h
index 590fc16..2011bcd 100644
--- a/src/dolphinpart_ext.h
+++ b/src/dolphinpart_ext.h
@@ -32,7 +32,7 @@ class DolphinPartBrowserExtension : public KParts::BrowserExtension
{
Q_OBJECT
public:
- DolphinPartBrowserExtension( DolphinPart* part );
+ explicit DolphinPartBrowserExtension( DolphinPart* part );
void restoreState(QDataStream &stream) override;
void saveState(QDataStream &stream) override;
@@ -52,7 +52,7 @@ class DolphinPartFileInfoExtension : public KParts::FileInfoExtension
Q_OBJECT
public:
- DolphinPartFileInfoExtension(DolphinPart* part);
+ explicit DolphinPartFileInfoExtension(DolphinPart* part);
QueryModes supportedQueryModes() const override;
bool hasSelection() const override;
@@ -68,7 +68,7 @@ class DolphinPartListingFilterExtension : public KParts::ListingFilterExtension
Q_OBJECT
public:
- DolphinPartListingFilterExtension(DolphinPart* part);
+ explicit DolphinPartListingFilterExtension(DolphinPart* part);
FilterModes supportedFilterModes() const override;
bool supportsMultipleFilters(FilterMode mode) const override;
QVariant filter(FilterMode mode) const override;
@@ -83,7 +83,7 @@ class DolphinPartListingNotificationExtension : public KParts::ListingNotificati
Q_OBJECT
public:
- DolphinPartListingNotificationExtension(DolphinPart* part);
+ explicit DolphinPartListingNotificationExtension(DolphinPart* part);
NotificationEventTypes supportedNotificationEventTypes() const override;
public Q_SLOTS:
diff --git a/src/kitemviews/kfileitemlistview.h b/src/kitemviews/kfileitemlistview.h
index 95ad9ba..c7fdf97 100644
--- a/src/kitemviews/kfileitemlistview.h
+++ b/src/kitemviews/kfileitemlistview.h
@@ -41,7 +41,7 @@ class DOLPHIN_EXPORT KFileItemListView : public KStandardItemListView
Q_OBJECT
public:
- KFileItemListView(QGraphicsWidget* parent = nullptr);
+ explicit KFileItemListView(QGraphicsWidget* parent = nullptr);
~KFileItemListView() override;
void setPreviewsShown(bool show);
diff --git a/src/kitemviews/kitemlistgroupheader.h b/src/kitemviews/kitemlistgroupheader.h
index 6a8bd76..ec5fb14 100644
--- a/src/kitemviews/kitemlistgroupheader.h
+++ b/src/kitemviews/kitemlistgroupheader.h
@@ -42,7 +42,7 @@ class DOLPHIN_EXPORT KItemListGroupHeader : public QGraphicsWidget
Q_OBJECT
public:
- KItemListGroupHeader(QGraphicsWidget* parent = nullptr);
+ explicit KItemListGroupHeader(QGraphicsWidget* parent = nullptr);
~KItemListGroupHeader() override;
void setRole(const QByteArray& role);
diff --git a/src/kitemviews/kitemlistheader.h b/src/kitemviews/kitemlistheader.h
index 4d9d9a5..ef1dd0f 100644
--- a/src/kitemviews/kitemlistheader.h
+++ b/src/kitemviews/kitemlistheader.h
@@ -87,7 +87,7 @@ signals:
qreal currentWidth);
private:
- KItemListHeader(KItemListView* listView);
+ explicit KItemListHeader(KItemListView* listView);
private:
KItemListView* m_view;
diff --git a/src/kitemviews/kitemlistselectionmanager.h b/src/kitemviews/kitemlistselectionmanager.h
index 54c2cc0..e4fe0c2 100644
--- a/src/kitemviews/kitemlistselectionmanager.h
+++ b/src/kitemviews/kitemlistselectionmanager.h
@@ -51,7 +51,7 @@ public:
Toggle
};
- KItemListSelectionManager(QObject* parent = nullptr);
+ explicit KItemListSelectionManager(QObject* parent = nullptr);
~KItemListSelectionManager() override;
void setCurrentItem(int current);
diff --git a/src/kitemviews/kitemlistview.h b/src/kitemviews/kitemlistview.h
index e3793e1..7af3d32 100644
--- a/src/kitemviews/kitemlistview.h
+++ b/src/kitemviews/kitemlistview.h
@@ -67,7 +67,7 @@ class DOLPHIN_EXPORT KItemListView : public QGraphicsWidget
Q_PROPERTY(qreal itemOffset READ itemOffset WRITE setItemOffset)
public:
- KItemListView(QGraphicsWidget* parent = nullptr);
+ explicit KItemListView(QGraphicsWidget* parent = nullptr);
~KItemListView() override;
/**
diff --git a/src/kitemviews/kitemmodelbase.h b/src/kitemviews/kitemmodelbase.h
index 0aa6d18..7db387e 100644
--- a/src/kitemviews/kitemmodelbase.h
+++ b/src/kitemviews/kitemmodelbase.h
@@ -55,7 +55,7 @@ class DOLPHIN_EXPORT KItemModelBase : public QObject
Q_OBJECT
public:
- KItemModelBase(QObject* parent = nullptr);
+ explicit KItemModelBase(QObject* parent = nullptr);
explicit KItemModelBase(const QByteArray& sortRole, QObject* parent = nullptr);
~KItemModelBase() override;
diff --git a/src/kitemviews/kitemrange.h b/src/kitemviews/kitemrange.h
index ecc0398..6453f21 100644
--- a/src/kitemviews/kitemrange.h
+++ b/src/kitemviews/kitemrange.h
@@ -51,7 +51,7 @@ class KItemRangeList : public QList<KItemRange>
{
public:
KItemRangeList() : QList<KItemRange>() {}
- KItemRangeList(const QList<KItemRange>& list) : QList<KItemRange>(list) {}
+ explicit KItemRangeList(const QList<KItemRange>& list) : QList<KItemRange>(list) {}
template<class Container>
static KItemRangeList fromSortedContainer(const Container& container);
diff --git a/src/kitemviews/kitemset.h b/src/kitemviews/kitemset.h
index 5afe24d..b831953 100644
--- a/src/kitemviews/kitemset.h
+++ b/src/kitemviews/kitemset.h
@@ -163,7 +163,7 @@ public:
{
}
- const_iterator(const iterator& other) :
+ explicit const_iterator(const iterator& other) :
m_rangeIt(other.m_rangeIt),
m_offset(other.m_offset)
{
diff --git a/src/kitemviews/kstandarditemlistgroupheader.h b/src/kitemviews/kstandarditemlistgroupheader.h
index 36ab777..136bb86 100644
--- a/src/kitemviews/kstandarditemlistgroupheader.h
+++ b/src/kitemviews/kstandarditemlistgroupheader.h
@@ -32,7 +32,7 @@ class DOLPHIN_EXPORT KStandardItemListGroupHeader : public KItemListGroupHeader
Q_OBJECT
public:
- KStandardItemListGroupHeader(QGraphicsWidget* parent = nullptr);
+ explicit KStandardItemListGroupHeader(QGraphicsWidget* parent = nullptr);
~KStandardItemListGroupHeader() override;
void paint(QPainter* painter, const QStyleOptionGraphicsItem* option, QWidget* widget = nullptr) override;
diff --git a/src/kitemviews/kstandarditemlistview.h b/src/kitemviews/kstandarditemlistview.h
index 6321a1d..f612562 100644
--- a/src/kitemviews/kstandarditemlistview.h
+++ b/src/kitemviews/kstandarditemlistview.h
@@ -52,7 +52,7 @@ public:
DetailsLayout
};
- KStandardItemListView(QGraphicsWidget* parent = nullptr);
+ explicit KStandardItemListView(QGraphicsWidget* parent = nullptr);
~KStandardItemListView() override;
void setItemLayout(ItemLayout layout);
diff --git a/src/kitemviews/private/kfileitemmodeldirlister.h b/src/kitemviews/private/kfileitemmodeldirlister.h
index c8b670f..b3f85c8 100644
--- a/src/kitemviews/private/kfileitemmodeldirlister.h
+++ b/src/kitemviews/private/kfileitemmodeldirlister.h
@@ -34,7 +34,7 @@ class DOLPHIN_EXPORT KFileItemModelDirLister : public KDirLister
Q_OBJECT
public:
- KFileItemModelDirLister(QObject* parent = nullptr);
+ explicit KFileItemModelDirLister(QObject* parent = nullptr);
~KFileItemModelDirLister() override;
signals:
diff --git a/src/kitemviews/private/kitemlistheaderwidget.h b/src/kitemviews/private/kitemlistheaderwidget.h
index 6d0974f..193f2b3 100644
--- a/src/kitemviews/private/kitemlistheaderwidget.h
+++ b/src/kitemviews/private/kitemlistheaderwidget.h
@@ -38,7 +38,7 @@ class DOLPHIN_EXPORT KItemListHeaderWidget : public QGraphicsWidget
Q_OBJECT
public:
- KItemListHeaderWidget(QGraphicsWidget* parent = nullptr);
+ explicit KItemListHeaderWidget(QGraphicsWidget* parent = nullptr);
~KItemListHeaderWidget() override;
void setModel(KItemModelBase* model);
diff --git a/src/kitemviews/private/kitemlistkeyboardsearchmanager.h b/src/kitemviews/private/kitemlistkeyboardsearchmanager.h
index 02dedef..f9d77d0 100644
--- a/src/kitemviews/private/kitemlistkeyboardsearchmanager.h
+++ b/src/kitemviews/private/kitemlistkeyboardsearchmanager.h
@@ -41,7 +41,7 @@ class DOLPHIN_EXPORT KItemListKeyboardSearchManager : public QObject
public:
- KItemListKeyboardSearchManager(QObject* parent = nullptr);
+ explicit KItemListKeyboardSearchManager(QObject* parent = nullptr);
~KItemListKeyboardSearchManager() override;
/**
diff --git a/src/kitemviews/private/kitemlistselectiontoggle.h b/src/kitemviews/private/kitemlistselectiontoggle.h
index a109953..a537a99 100644
--- a/src/kitemviews/private/kitemlistselectiontoggle.h
+++ b/src/kitemviews/private/kitemlistselectiontoggle.h
@@ -34,7 +34,7 @@ class DOLPHIN_EXPORT KItemListSelectionToggle : public QGraphicsWidget
Q_OBJECT
public:
- KItemListSelectionToggle(QGraphicsItem* parent);
+ explicit KItemListSelectionToggle(QGraphicsItem* parent);
~KItemListSelectionToggle() override;
void setChecked(bool checked);
diff --git a/src/kitemviews/private/kitemlistsizehintresolver.h b/src/kitemviews/private/kitemlistsizehintresolver.h
index fa92b86..b62c87a 100644
--- a/src/kitemviews/private/kitemlistsizehintresolver.h
+++ b/src/kitemviews/private/kitemlistsizehintresolver.h
@@ -34,7 +34,7 @@ class KItemListView;
class DOLPHIN_EXPORT KItemListSizeHintResolver
{
public:
- KItemListSizeHintResolver(const KItemListView* itemListView);
+ explicit KItemListSizeHintResolver(const KItemListView* itemListView);
virtual ~KItemListSizeHintResolver();
QSizeF maxSizeHint();
QSizeF minSizeHint();
diff --git a/src/kitemviews/private/kitemlistviewanimation.h b/src/kitemviews/private/kitemlistviewanimation.h
index ba3a33d..f73ea7f 100644
--- a/src/kitemviews/private/kitemlistviewanimation.h
+++ b/src/kitemviews/private/kitemlistviewanimation.h
@@ -48,7 +48,7 @@ public:
ResizeAnimation
};
- KItemListViewAnimation(QObject* parent = nullptr);
+ explicit KItemListViewAnimation(QObject* parent = nullptr);
~KItemListViewAnimation() override;
void setScrollOrientation(Qt::Orientation orientation);
diff --git a/src/kitemviews/private/kitemlistviewlayouter.h b/src/kitemviews/private/kitemlistviewlayouter.h
index 2116f84..6cdce66 100644
--- a/src/kitemviews/private/kitemlistviewlayouter.h
+++ b/src/kitemviews/private/kitemlistviewlayouter.h
@@ -50,7 +50,7 @@ class DOLPHIN_EXPORT KItemListViewLayouter : public QObject
Q_OBJECT
public:
- KItemListViewLayouter(KItemListSizeHintResolver* sizeHintResolver, QObject* parent = nullptr);
+ explicit KItemListViewLayouter(KItemListSizeHintResolver* sizeHintResolver, QObject* parent = nullptr);
~KItemListViewLayouter() override;
void setScrollOrientation(Qt::Orientation orientation);
diff --git a/src/middleclickactioneventfilter.h b/src/middleclickactioneventfilter.h
index 6974f46..e88eabc 100644
--- a/src/middleclickactioneventfilter.h
+++ b/src/middleclickactioneventfilter.h
@@ -35,7 +35,7 @@ class DOLPHIN_EXPORT MiddleClickActionEventFilter : public QObject
Q_OBJECT
public:
- MiddleClickActionEventFilter(QObject *parent);
+ explicit MiddleClickActionEventFilter(QObject *parent);
~MiddleClickActionEventFilter() override;
signals:
diff --git a/src/panels/information/phononwidget.h b/src/panels/information/phononwidget.h
index 947f0cd..eff613b 100644
--- a/src/panels/information/phononwidget.h
+++ b/src/panels/information/phononwidget.h
@@ -43,7 +43,7 @@ class PhononWidget : public QWidget
{
Q_OBJECT
public:
- PhononWidget(QWidget *parent = nullptr);
+ explicit PhononWidget(QWidget *parent = nullptr);
void setUrl(const QUrl &url);
QUrl url() const;
diff --git a/src/panels/places/placesitemlistgroupheader.h b/src/panels/places/placesitemlistgroupheader.h
index 4408aa9..7276622 100644
--- a/src/panels/places/placesitemlistgroupheader.h
+++ b/src/panels/places/placesitemlistgroupheader.h
@@ -27,7 +27,7 @@ class PlacesItemListGroupHeader : public KStandardItemListGroupHeader
Q_OBJECT
public:
- PlacesItemListGroupHeader(QGraphicsWidget* parent = nullptr);
+ explicit PlacesItemListGroupHeader(QGraphicsWidget* parent = nullptr);
~PlacesItemListGroupHeader() override;
protected:
diff --git a/src/settings/general/confirmationssettingspage.h b/src/settings/general/confirmationssettingspage.h
index f8e5e35..22e47ae 100644
--- a/src/settings/general/confirmationssettingspage.h
+++ b/src/settings/general/confirmationssettingspage.h
@@ -31,7 +31,7 @@ class ConfirmationsSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- ConfirmationsSettingsPage(QWidget* parent);
+ explicit ConfirmationsSettingsPage(QWidget* parent);
~ConfirmationsSettingsPage() override;
/** @see SettingsPageBase::applySettings() */
diff --git a/src/settings/general/previewssettingspage.h b/src/settings/general/previewssettingspage.h
index 0bac4da..875c19d 100644
--- a/src/settings/general/previewssettingspage.h
+++ b/src/settings/general/previewssettingspage.h
@@ -34,7 +34,7 @@ class PreviewsSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- PreviewsSettingsPage(QWidget* parent);
+ explicit PreviewsSettingsPage(QWidget* parent);
~PreviewsSettingsPage() override;
/**
diff --git a/src/settings/general/statusbarsettingspage.h b/src/settings/general/statusbarsettingspage.h
index d85f0aa..3c0bd2b 100644
--- a/src/settings/general/statusbarsettingspage.h
+++ b/src/settings/general/statusbarsettingspage.h
@@ -31,7 +31,7 @@ class StatusBarSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- StatusBarSettingsPage(QWidget* parent);
+ explicit StatusBarSettingsPage(QWidget* parent);
~StatusBarSettingsPage() override;
/** @see SettingsPageBase::applySettings() */
diff --git a/src/settings/navigation/navigationsettingspage.h b/src/settings/navigation/navigationsettingspage.h
index d58a8e8..188fe51 100644
--- a/src/settings/navigation/navigationsettingspage.h
+++ b/src/settings/navigation/navigationsettingspage.h
@@ -31,7 +31,7 @@ class NavigationSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- NavigationSettingsPage(QWidget* parent);
+ explicit NavigationSettingsPage(QWidget* parent);
~NavigationSettingsPage() override;
/** @see SettingsPageBase::applySettings() */
diff --git a/src/settings/services/servicessettingspage.h b/src/settings/services/servicessettingspage.h
index c1239c9..bcbce19 100644
--- a/src/settings/services/servicessettingspage.h
+++ b/src/settings/services/servicessettingspage.h
@@ -35,7 +35,7 @@ class ServicesSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- ServicesSettingsPage(QWidget* parent);
+ explicit ServicesSettingsPage(QWidget* parent);
~ServicesSettingsPage() override;
/** @see SettingsPageBase::applySettings() */
diff --git a/src/settings/trash/trashsettingspage.h b/src/settings/trash/trashsettingspage.h
index 57631b7..6faf3f6 100644
--- a/src/settings/trash/trashsettingspage.h
+++ b/src/settings/trash/trashsettingspage.h
@@ -30,7 +30,7 @@ class TrashSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- TrashSettingsPage(QWidget* parent);
+ explicit TrashSettingsPage(QWidget* parent);
~TrashSettingsPage() override;
/** @see SettingsPageBase::applySettings() */
diff --git a/src/settings/viewmodes/dolphinfontrequester.h b/src/settings/viewmodes/dolphinfontrequester.h
index 3f355e3..6f1b840 100644
--- a/src/settings/viewmodes/dolphinfontrequester.h
+++ b/src/settings/viewmodes/dolphinfontrequester.h
@@ -40,7 +40,7 @@ public:
CustomFont = 1
};
- DolphinFontRequester(QWidget* parent);
+ explicit DolphinFontRequester(QWidget* parent);
~DolphinFontRequester() override;
void setMode(Mode mode);
diff --git a/src/settings/viewmodes/viewmodesettings.h b/src/settings/viewmodes/viewmodesettings.h
index 9f0b44e..8bc9b56 100644
--- a/src/settings/viewmodes/viewmodesettings.h
+++ b/src/settings/viewmodes/viewmodesettings.h
@@ -36,7 +36,7 @@ public:
DetailsMode
};
- ViewModeSettings(ViewMode mode);
+ explicit ViewModeSettings(ViewMode mode);
virtual ~ViewModeSettings();
void setIconSize(int size) const;
diff --git a/src/settings/viewmodes/viewsettingspage.h b/src/settings/viewmodes/viewsettingspage.h
index 4f57e5c..2e456a8 100644
--- a/src/settings/viewmodes/viewsettingspage.h
+++ b/src/settings/viewmodes/viewsettingspage.h
@@ -36,7 +36,7 @@ class ViewSettingsPage : public SettingsPageBase
Q_OBJECT
public:
- ViewSettingsPage(QWidget* parent);
+ explicit ViewSettingsPage(QWidget* parent);
~ViewSettingsPage() override;
/** @see SettingsPageBase::applySettings() */
diff --git a/src/statusbar/dolphinstatusbar.h b/src/statusbar/dolphinstatusbar.h
index 0b0004e..8b872ac 100644
--- a/src/statusbar/dolphinstatusbar.h
+++ b/src/statusbar/dolphinstatusbar.h
@@ -43,7 +43,7 @@ class DolphinStatusBar : public QWidget
Q_OBJECT
public:
- DolphinStatusBar(QWidget* parent);
+ explicit DolphinStatusBar(QWidget* parent);
~DolphinStatusBar() override;
QString text() const;
diff --git a/src/views/tooltips/dolphinfilemetadatawidget.h b/src/views/tooltips/dolphinfilemetadatawidget.h
index 6dcc523..3017ef5 100644
--- a/src/views/tooltips/dolphinfilemetadatawidget.h
+++ b/src/views/tooltips/dolphinfilemetadatawidget.h
@@ -45,7 +45,7 @@ class DolphinFileMetaDataWidget : public QWidget
Q_OBJECT
public:
- DolphinFileMetaDataWidget(QWidget* parent = nullptr);
+ explicit DolphinFileMetaDataWidget(QWidget* parent = nullptr);
~DolphinFileMetaDataWidget() override;
void setPreview(const QPixmap& pixmap);